Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor : migrate test-infra to testify for batch_point_get_test.go #29117

Merged
merged 14 commits into from
Oct 28, 2021
Merged

executor : migrate test-infra to testify for batch_point_get_test.go #29117

merged 14 commits into from
Oct 28, 2021

Conversation

YufeiCh
Copy link
Contributor

@YufeiCh YufeiCh commented Oct 26, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #28566
Issue Number: close #28573
Issue Number: close #28583

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2021
@YufeiCh
Copy link
Contributor Author

YufeiCh commented Oct 27, 2021

/run-check_dev_2

@YufeiCh
Copy link
Contributor Author

YufeiCh commented Oct 27, 2021

/cc @tisonkun

@ti-chi-bot ti-chi-bot requested a review from tisonkun October 27, 2021 07:57
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
tisonkun
tisonkun reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. It looks clean. Comments inline.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2021
@tisonkun
Copy link
Contributor

/cc @guo-shaoge

@ti-chi-bot ti-chi-bot requested a review from guo-shaoge October 28, 2021 01:56
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2021
@tisonkun
Copy link
Contributor

/cc @mmyj

@ti-chi-bot ti-chi-bot requested a review from mmyj October 28, 2021 02:39
@mmyj
Copy link
Member

mmyj commented Oct 28, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 00b3393

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2021
@ti-chi-bot
Copy link
Member

@YufeiCh: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5017818 into pingcap:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@mmyj mmyj Awaiting requested review from mmyj

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@YufeiCh @ti-chi-bot @tisonkun @mmyj @guo-shaoge